Privacy Panel new pull request #25688

martapiekarska · 2014-10-31T08:12:48Z

This is a new pull request. We had to remove the old one due to big problems with git and some Schroedinger patches....

try-server-hook · 2014-10-31T08:13:34Z

zbraniecki · 2014-10-31T08:23:15Z

apps/privacy-panel/js/sms/main.js

+        lon = pos.coords.longitude;
+
+        this._sendSMS(number, navigator.mozL10n.get('sms-locate', {
+          coords: lat + ',' + lon


even better to pass lat and lon separately and let localizers use the local presentation form for coordinates.

etiennesegonzac · 2014-10-31T15:08:01Z

Looks like we're missing all the binay files again... (not completely blocking)

etiennesegonzac · 2014-10-31T15:11:24Z

apps/privacy-panel/js/sms/main.js

+        }.bind(this), 3000);
+      }.bind(this);
+
+      Commands.invokeCommand('ring', [86400, ringReply]);


we're then multiplying by 1000 the duration in commands.js...
so my phone will be ringing for more than 2 years I think :) not so sure about the UX...

They wanted the phone to ring infinetly...

shouldn't we stop when the phone is unlocked?

note: anybody can long press the power button, restart the phone and stop the ringer

How long the limit should be?

corrected to no multiplication

Guys, this value represents only 1 day :) not 2 years.
60 sec * 60 min * 24h = 86400
and javascripts timestamps are with miliseconds so thats why this was multipled by 1000

Ad2 New patch should also have ability to stop ringer.

try-server-hook · 2014-10-31T15:23:58Z

martasect started tests. Results

try-server-hook · 2014-10-31T15:28:01Z

martasect started tests. Results

martapiekarska · 2014-10-31T15:28:09Z

I have added the binaries/

etiennesegonzac · 2014-10-31T15:33:49Z

apps/privacy-panel/build/build.js

@@ -0,0 +1,28 @@
+'use strict';


I'm pretty sure we can rm -r apps/privacy-panel/build

Yes, project will work, but build config allow us to combine all files into one file thanks to requirejs optimizer.

the gaia build system also does this kind of optimizations, so it might be redundant.
anyway, I'm fine with it if we have make test-perf results showing that it helps, otherwise we shouldn't add the complexity

etiennesegonzac · 2014-10-31T16:56:28Z

we will need marionette tests for the interaction with the settings app.

launching from the settings app then going back
being sent to the passcode screen in the system app when enabling RPP

etiennesegonzac · 2014-10-31T16:59:02Z

apps/privacy-panel/style/panels.css

+}
+
+.icon-gt {
+  background-image: url("images/gt.png");


we probably want to test background-size for those to prevent the weird "big icon rendering" on the main screen

could you elaborate on that, please? How would you like to test this?

This is not the intended design right?

please, test UI's like this using pseudolocales. They add ~30% to the string length which is what usually makes the text fit for most locales. The middle string seems like it may not fit.

try-server-hook · 2014-11-03T19:47:56Z

martasect started tests. Results

zbraniecki · 2014-11-19T16:45:50Z

apps/privacy-panel/test/unit/sms/main_test.js

+      realMozSettings = navigator.mozSettings;
+      navigator.mozSettings = mozSettings;
+
+      navigator.mozL10n = { get: function() {} };


that enables you to remove mozL10n from this tests and just test for L10nAttrs object or string being passed into _sendSMS.

try-server-hook · 2014-11-21T10:09:44Z

martasect started tests. Results

EragonJ · 2014-11-24T02:37:54Z

apps/settings/test/unit/panels/root/privacy_panel_item_test.js

+    // lets wait till Promise resolve privacy-panel app.
+    this.subject._getApp().then(function() {
+      done();
+    });


nit: we have to add one more function to avoid this _getApp() is rejected (This would not happen and should not happen), and if that happen, we should throw out error. And no matter _getApp() is resolved or rejected, we should always call done to make sure tests can be run.

Please check https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/unit/modules/apps_cache_test.js#L48

try-server-hook · 2014-11-24T11:20:56Z

martasect started tests. Results

try-server-hook · 2014-11-24T15:15:07Z

martasect started tests. Results

try-server-hook · 2014-11-25T14:18:36Z

martasect started tests. Results

try-server-hook · 2014-11-25T14:58:33Z

martasect started tests. Results

try-server-hook · 2014-11-25T15:00:41Z

martasect started tests. Results

KevinGrandon · 2014-11-25T19:01:56Z

Closing in favor of: 0f7bb15

zbraniecki reviewed Oct 31, 2014
View reviewed changes

etiennesegonzac reviewed Oct 31, 2014
View reviewed changes

martapiekarska force-pushed the privacy-panel-master-apps branch from 4d3360f to 85e4e2c Compare November 3, 2014 19:47

martapiekarska force-pushed the privacy-panel-master-apps branch from 85e4e2c to 2d66047 Compare November 4, 2014 22:42

zbraniecki reviewed Nov 19, 2014
View reviewed changes

martapiekarska force-pushed the privacy-panel-master-apps branch from 4a016e4 to b3b7975 Compare November 21, 2014 10:08

EragonJ reviewed Nov 24, 2014
View reviewed changes

martapiekarska force-pushed the privacy-panel-master-apps branch from b3b7975 to f3a6f04 Compare November 24, 2014 11:20

martapiekarska force-pushed the privacy-panel-master-apps branch from f3a6f04 to dc9a0db Compare November 24, 2014 15:14

martapiekarska force-pushed the privacy-panel-master-apps branch from dc9a0db to 04b75a2 Compare November 25, 2014 14:16

martapiekarska force-pushed the privacy-panel-master-apps branch from 04b75a2 to 68d43c5 Compare November 25, 2014 14:57

Privacy Panel new pull request

c7aeffc

martapiekarska force-pushed the privacy-panel-master-apps branch from 68d43c5 to c7aeffc Compare November 25, 2014 14:59

KevinGrandon closed this Nov 25, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Privacy Panel new pull request #25688

Privacy Panel new pull request #25688

martapiekarska commented Oct 31, 2014

try-server-hook commented Oct 31, 2014

zbraniecki Oct 31, 2014

etiennesegonzac commented Oct 31, 2014

etiennesegonzac Oct 31, 2014

martapiekarska Oct 31, 2014

etiennesegonzac Oct 31, 2014

martapiekarska Nov 6, 2014

martapiekarska Nov 7, 2014

kukomigo Nov 7, 2014

try-server-hook commented Oct 31, 2014

try-server-hook commented Oct 31, 2014

martapiekarska commented Oct 31, 2014

etiennesegonzac Oct 31, 2014

kukomigo Nov 3, 2014

etiennesegonzac Nov 5, 2014

martapiekarska Nov 7, 2014

etiennesegonzac commented Oct 31, 2014

etiennesegonzac Oct 31, 2014

martapiekarska Nov 4, 2014

etiennesegonzac Nov 5, 2014

zbraniecki Nov 6, 2014

try-server-hook commented Nov 3, 2014

zbraniecki Nov 19, 2014

wojciech-lakomy Nov 21, 2014

try-server-hook commented Nov 21, 2014

EragonJ Nov 24, 2014

wojciech-lakomy Nov 24, 2014

try-server-hook commented Nov 24, 2014

try-server-hook commented Nov 24, 2014

try-server-hook commented Nov 25, 2014

try-server-hook commented Nov 25, 2014

try-server-hook commented Nov 25, 2014

KevinGrandon commented Nov 25, 2014

Privacy Panel new pull request #25688

Privacy Panel new pull request #25688

Conversation

martapiekarska commented Oct 31, 2014

try-server-hook commented Oct 31, 2014

Choose a reason for hiding this comment

etiennesegonzac commented Oct 31, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

try-server-hook commented Oct 31, 2014

try-server-hook commented Oct 31, 2014

martapiekarska commented Oct 31, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etiennesegonzac commented Oct 31, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

try-server-hook commented Nov 3, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

try-server-hook commented Nov 21, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

try-server-hook commented Nov 24, 2014

try-server-hook commented Nov 24, 2014

try-server-hook commented Nov 25, 2014

try-server-hook commented Nov 25, 2014

try-server-hook commented Nov 25, 2014

KevinGrandon commented Nov 25, 2014